Attention is currently required from: Amanda Hwang.
Paul Menzel has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/85206?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/fatcat/var/francka: Change RAM_ID to 1
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85206/comment/1e813152_5a706567?usp... :
PS1, Line 7: Change RAM_ID to 1
Maybe:
Use RAM ID 1 for MT62F2G32D4DS-020 WT:F
https://review.coreboot.org/c/coreboot/+/85206/comment/338e0a3f_5d111fe5?usp... :
PS1, Line 11:
Out of curiosity: What is the actual problem? Is 0 reserved for the empty SPD?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85206?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8cf0e65036c2da7641f29b2975dece718f7c83e3
Gerrit-Change-Number: 85206
Gerrit-PatchSet: 1
Gerrit-Owner: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 21 Nov 2024 09:01:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No