Attention is currently required from: Pratikkumar V Prajapati.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74769?usp=email )
Change subject: soc/intel/meteorlake: Add support for crashlog ......................................................................
Patch Set 29:
(1 comment)
Patchset:
PS23:
Log from my system
[DEBUG] Region[0x0].Tag=0x7 offset=0x9b, size=0x400 [DEBUG] Region[0x1].Tag=0x0 offset=0xa00, size=0x280 [DEBUG] Region[0x2].Tag=0x0 offset=0x2bb0, size=0xa [DEBUG] Region[0x3].Tag=0x0 offset=0x3a00, size=0x80 [DEBUG] Region[0x4].Tag=0x1 offset=0x780, size=0x280 [DEBUG] Region[0x5].Tag=0x1 offset=0x12d8, size=0xa [DEBUG] Region[0x6].Tag=0x1 offset=0x1600, size=0x6e [DEBUG] Region[0x7].Tag=0x0 offset=0x0, size=0x0 [DEBUG] Region[0x0].Tag=0x7 offset=0x9b, size=0x400 [DEBUG] Region[0x1].Tag=0x0 offset=0xa00, size=0x280 [DEBUG] Region[0x2].Tag=0x0 offset=0x2bb0, size=0xa [DEBUG] Region[0x3].Tag=0x0 offset=0x3a00, size=0x80 [DEBUG] Region[0x4].Tag=0x1 offset=0x780, size=0x280 [DEBUG] Region[0x5].Tag=0x1 offset=0x12d8, size=0xa [DEBUG] Region[0x6].Tag=0x1 offset=0x1600, size=0x6e
make sense to use associated string rather using TAG ids for debug prints ?
I can add this in separate patch. For now, lets merge this patch
Any timeline when you should be able to start with refactoring this code. A lot of cleaning up in required