Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42846 )
Change subject: soc/amd/picasso: add NULL-pointer check to root_complex_fill_ssdt
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42846/3/src/soc/amd/picasso/root_co...
File src/soc/amd/picasso/root_complex.c:
https://review.coreboot.org/c/coreboot/+/42846/3/src/soc/amd/picasso/root_co...
PS3, Line 138: if (!device) {
It should have just been an assert or something. The ops which this function is a part of cannot be called with NULL. the ops are inherently bound by the __pci_driver.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42846
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia72b9dbe029a5da98e408a9cf16fa4a93b10917a
Gerrit-Change-Number: 42846
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Jun 2020 14:55:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment