Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29480 )
Change subject: mb/kontron/bsl6: Add new Skylake COMe module ......................................................................
Patch Set 29: Code-Review+1
(3 comments)
Looks very good! :)
beside my mess with the GPIO comments ._.
https://review.coreboot.org/c/coreboot/+/29480/29/src/mainboard/kontron/bsl6... File src/mainboard/kontron/bsl6/Kconfig:
https://review.coreboot.org/c/coreboot/+/29480/29/src/mainboard/kontron/bsl6... PS29, Line 21: select DRIVERS_I2C_LM96000 if BOARD_SIEMENS_BOXER26
https://review.coreboot.org/c/coreboot/+/29480/29/src/mainboard/kontron/bsl6... PS29, Line 46: config CBFS_SIZE : hex : default 0x600000 Did I set this? ^^
Not overriding this allows convenient, faster flashing...
https://review.coreboot.org/c/coreboot/+/29480/29/src/mainboard/kontron/bsl6... File src/mainboard/kontron/bsl6/gpio.h:
https://review.coreboot.org/c/coreboot/+/29480/29/src/mainboard/kontron/bsl6... PS29, Line 226: PAD_CFG_NF(GPP_I10, NONE, PLTRST, NF1), Some of the comments are stale (my fault). I wonder if we should remove them all. Maintaining the names at board level is all wrong. As tedious as it might seem, we could instead maintain aliases for the NF* macros at SoC level, that's actually less work than maintaining stupid comments.