Attention is currently required from: Martin L Roth, Nico Huber, Paul Menzel.
Hello Martin L Roth, Nico Huber, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83476?usp=email
to look at the new patch set (#2).
Change subject: bootsplash: Increase heap from 1 MB to 4 MB when bootsplash is enabled ......................................................................
bootsplash: Increase heap from 1 MB to 4 MB when bootsplash is enabled
Since commit 1d029b40c9de ("lib/jpeg: Replace decoder with Wuffs' implementation"), a relatively large heap allocation is needed to decode many JPEGs for use as work area. The prior decoder did not need this, but also had many limitations in the JPEGs it could decode.
A 1024x768 non-progressive JPEG used in Heads needs 1179648 bytes of work area; about 1.2 MB. While the work area will also depend on the subsampling of each channel, it's generally proportional to the image size.
Increasing the heap size to 4 MB when bootsplash is enabled should be enough to decode bootsplashes up to 1920x1080 with some headroom.
Change-Id: Ia4348d39effbc16c1b42ab01bcf1e4ec5d652fa9 Signed-off-by: Jonathon Hall jonathon.hall@puri.sm --- M src/device/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/83476/2