Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83572?usp=email )
Change subject: soc/mediatek/mt8196: Add a stub implementation of the MT8196 SoC
......................................................................
Patch Set 1:
(2 comments)
File src/soc/mediatek/mt8196/Makefile.inc:
PS1:
Makefiles should be Makefile.mk not Makefile.inc
https://review.coreboot.org/c/coreboot/+/83572/comment/63cdc8da_10be87ac?usp... :
PS1, Line 1: ifeq ($(CONFIG_SOC_MEDIATEK_MT8196),y)
src/soc/mediatek/mt8196/Makefile.inc has no recognized SPDX identifier.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83572?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8190253ed000db879b04a806ca0bdf29c14be806
Gerrit-Change-Number: 83572
Gerrit-PatchSet: 1
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Fri, 19 Jul 2024 08:08:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No