Attention is currently required from: Jamie Ryu, Wonkyu Kim, Subrata Banik, Ethan Tsao, Ravishankar Sarawadi, Angel Pons, Nick Vaccaro, Tim Wawrzynczak. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63170 )
Change subject: intel/common/block: Add gpmr common driver ......................................................................
Patch Set 13:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63170/comment/591ee84e_4cf7f926 PS13, Line 8: Please elaborate, what GPMR is, and what you used as base of your implemenation.
File src/soc/intel/common/block/gpmr/Kconfig:
https://review.coreboot.org/c/coreboot/+/63170/comment/88321c49_305ca04c PS13, Line 6: Required for extending BIOS region. Please spell out what GPMR means.
File src/soc/intel/common/block/gpmr/gpmr.c:
https://review.coreboot.org/c/coreboot/+/63170/comment/08380ea9_99051e0d PS13, Line 28: /* Check for available free gpmr */ As the function is well named, remove the redundant comment.
https://review.coreboot.org/c/coreboot/+/63170/comment/1f7db73a_ce50c107 PS13, Line 29: static int get_available_gpmr(void) Mixing CB_ERR and returning values is not wanted I think.
https://review.coreboot.org/c/coreboot/+/63170/comment/5ecd38a0_1829f862 PS13, Line 31: int i; unsigned int
https://review.coreboot.org/c/coreboot/+/63170/comment/bac8959a_d32b92ab PS13, Line 44: uint32_t size_t?
https://review.coreboot.org/c/coreboot/+/63170/comment/36108749_a8bc1fc4 PS13, Line 46: int unsigned int
https://review.coreboot.org/c/coreboot/+/63170/comment/75be343c_defce517 PS13, Line 71: Range range