Attention is currently required from: Raul Rangel, Jon Murphy, Mark Hasemeyer.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74110 )
Change subject: mb/google/myst: Add eSPI configuration
......................................................................
Patch Set 33:
(1 comment)
File src/mainboard/google/myst/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/74110/comment/6120bec6_e2520c97
PS33, Line 22: 255
hmm, this should probably be 256. it's also 255 on all other amd zen based chromebooks, but this is likely missing the last byte on all. the io region above uses the expected 256 bytes which also points at the 255 being wrong.
espi_write_io_window already subtracts the 1 from the size struct element to get the correct register value
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74110
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b40adec78d4e0b596596fa6e2951c79bd3bd8c7
Gerrit-Change-Number: 74110
Gerrit-PatchSet: 33
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Thu, 20 Apr 2023 09:12:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment