Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43195 )
Change subject: soc/intel/baytrail/lpss.c: Align with Braswell
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43195/2/src/soc/intel/baytrail/lpss...
File src/soc/intel/baytrail/lpss.c:
https://review.coreboot.org/c/coreboot/+/43195/2/src/soc/intel/baytrail/lpss...
PS2, Line 22: (1 << 10)
how about change both to use PCI_COMMAND_INT_DISABLE ?
Sounds good. I'll see if there are any other instances around.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43195
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98d17fc470149b181e8d92b8bcc5d99c68299212
Gerrit-Change-Number: 43195
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Sat, 25 Jul 2020 00:29:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment