build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39313 )
Change subject: soc/intel/tigerlake: Correct order of "RUN_FSP_GOP" check ......................................................................
Patch Set 1:
(10 comments)
https://review.coreboot.org/c/coreboot/+/39313/1/src/soc/intel/tigerlake/gra... File src/soc/intel/tigerlake/graphics.c:
https://review.coreboot.org/c/coreboot/+/39313/1/src/soc/intel/tigerlake/gra... PS1, Line 48: * GFX PEIM module inside FSP binary is taking care of graphics code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39313/1/src/soc/intel/tigerlake/gra... PS1, Line 49: * initialization based on RUN_FSP_GOP Kconfig code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39313/1/src/soc/intel/tigerlake/gra... PS1, Line 50: * option and input VBT file. Hence no need to load/execute legacy VGA code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39313/1/src/soc/intel/tigerlake/gra... PS1, Line 51: * OpROM in order to initialize GFX. code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39313/1/src/soc/intel/tigerlake/gra... PS1, Line 52: * code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39313/1/src/soc/intel/tigerlake/gra... PS1, Line 53: * In case of non-FSP solution, SoC need to select VGA_ROM_RUN code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39313/1/src/soc/intel/tigerlake/gra... PS1, Line 54: * Kconfig to perform GFX initialization through VGA OpRom. code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39313/1/src/soc/intel/tigerlake/gra... PS1, Line 55: */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39313/1/src/soc/intel/tigerlake/gra... PS1, Line 57: return; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39313/1/src/soc/intel/tigerlake/gra... PS1, Line 57: return; please, no spaces at the start of a line