8 Dec
2020
8 Dec
'20
8:42 a.m.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46389 )
Change subject: soc/mediatek/mt8192: add spmfw loader ......................................................................
Patch Set 36:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46389/36/src/soc/mediatek/mt8192/Ma... File src/soc/mediatek/mt8192/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46389/36/src/soc/mediatek/mt8192/Ma... PS36, Line 53: mcu-firmware-files := $(CONFIG_SPM_FIRMWARE)
let's make this multiline: […]
Hi Hung-Te,
Which style do you prefer ?
mcu-firmware-files := \ $(CONFIG_MCUPM_FIRMWARE) $(CONFIG_SPM_FIRMWARE) or mcu-firmware-files := \ $(CONFIG_MCUPM_FIRMWARE) \ $(CONFIG_SPM_FIRMWARE)
--
To view, visit https://review.coreboot.org/c/coreboot/+/46389
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6478b98f426d2f3e0ee919d37d21d909ae8a6371
Gerrit-Change-Number: 46389
Gerrit-PatchSet: 36
Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nicolas Boichat drinkcat@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com
Gerrit-Reviewer: Roger Lu roger.lu@mediatek.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nicolas Boichat drinkcat@chromium.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com
Gerrit-CC: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Tue, 08 Dec 2020 07:42:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org
Gerrit-MessageType: comment