Attention is currently required from: Paul Menzel, Nikolai Vyssotski.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58282 )
Change subject: mb/google/guybrush: Disable HAVE_ACPI_RESUME / S3
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58282/comment/d53ace80_ab570503
PS1, Line 9: S3 is not currently functional on Guybrush.
What does that mean exactly? Where does it fail? […]
It's not a regression, S3 support on Cezanne is still under development by AMD. The details are outside the scope of this CL and are detailed in b/181766974. S0i3 is working, so S3 support is low priority.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58282
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ed3e051f7f2e411670649ac2528a6f40229bdc6
Gerrit-Change-Number: 58282
Gerrit-PatchSet: 2
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Comment-Date: Wed, 13 Oct 2021 18:33:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment