Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31682 )
Change subject: driver/intel/ish: add ish chip driver support
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31682/1/src/drivers/intel/ish/Kconfig
File src/drivers/intel/ish/Kconfig:
https://review.coreboot.org/#/c/31682/1/src/drivers/intel/ish/Kconfig@2
PS1, Line 2: bool "Support Intel ISH driver that publishes _DSD information"
Do we want this user selectable or just selected automatically in SoC or mainboard Kconfig?
I had it selectable so you don't need extra drivers.
For sarien, I only include this for the arcada build. See https://review.coreboot.org/c/coreboot/+/31683/1/src/mainboard/google/sarien...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31682
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id8be986185282521aee574027503eaf8968e1508
Gerrit-Change-Number: 31682
Gerrit-PatchSet: 1
Gerrit-Owner: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Fri, 01 Mar 2019 17:46:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment