Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31474 )
Change subject: vboot: standardize on working data size ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31474/1/src/security/vboot/vboot_loader.c File src/security/vboot/vboot_loader.c:
https://review.coreboot.org/#/c/31474/1/src/security/vboot/vboot_loader.c@37 PS1, Line 37: == Also considering making this >=, but I'm not sure if there ever would be an actual case that only a specific platform needs more space for firmware verification?
https://review.coreboot.org/#/c/31474/1/src/soc/cavium/cn81xx/include/soc/me... File src/soc/cavium/cn81xx/include/soc/memlayout.ld:
https://review.coreboot.org/#/c/31474/1/src/soc/cavium/cn81xx/include/soc/me... PS1, Line 37: ) Actually, I'm still on the fence of whether hard-coding a number here is still a better option. If we ever increased the global config value, it could mess up the regions following this one if they overlap.
Any recommendations?