Attention is currently required from: Michael Niewöhner, Nicholas Chin, Nicholas Sudsgaard.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80695?usp=email )
Change subject: include/device: Merge enums from azalia_device.h and azalia.h ......................................................................
Patch Set 4:
(3 comments)
File src/include/device/azalia_device.h:
https://review.coreboot.org/c/coreboot/+/80695/comment/3aeeffce_2d29a332 : PS4, Line 128: conn
That would open a can of worms once you start using more "complex" things. […]
Ack. Be careful with vendor values, though. If they are hard to express, it's often because they are wrong.
File src/mainboard/siemens/chili/variants/chili/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/80695/comment/64cd5a23_61d06da1 : PS4, Line 17: /* 0x14 Speaker OUT */
Maybe we can drop these comments.
I would like to keep them. It's still much easier to parse than the all-caps macro list.
https://review.coreboot.org/c/coreboot/+/80695/comment/ecbf556d_d245c33e : PS4, Line 26: 0x0 There's no reason to make these hex numbers, is there? I was first wondering why we have magic numbers here at all, then realized that it's kind of a counter / id. Feels more natural to have decimals.