Attention is currently required from: Maximilian Brune.
Julius Werner has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83085?usp=email )
Change subject: commonlib/device_tree.c: Fix results length check ......................................................................
Patch Set 4:
(1 comment)
File src/lib/device_tree.c:
https://review.coreboot.org/c/coreboot/+/83085/comment/73be31bd_4bd8e3d4?usp... : PS1, Line 363: if (count_results > results_len) {
The current implementation should work. But I am thinking of just ditching the warning. […]
Hmm... yeah, realistically, for almost all nodes (except the `/memory` ones), if they have multiple reg areas the caller needs to know specifically what each of them means anyway (either intrinsically or via something like `reg-names`), otherwise it wouldn't know what to do with the remaining entries. And there may be legitimate situations where a caller knows it only wants to read the first X entries even if there may be more. So maybe dropping the warning makes most sense.