Attention is currently required from: Subrata Banik, Christian Walter, Nick Vaccaro. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61720 )
Change subject: drivers/i2c/tpm/cr50: Add support to get cr50 firmware version ......................................................................
Patch Set 4:
(4 comments)
File src/drivers/i2c/tpm/cr50.c:
https://review.coreboot.org/c/coreboot/+/61720/comment/cc384b37_168c98a7 PS3, Line 487: -2
Unable to understand how line #518 (the caller) would differentiate between function returning -1 or […]
Eh right now it doesn't/don't care, I will change to all -1 or 0.
https://review.coreboot.org/c/coreboot/+/61720/comment/3dbde2dd_3a86fdc6 PS3, Line 503: 301
I see this is the same as in the spi version. […]
No, I don't think it does, but I think that is just the maximum depth of cr50 FIFO maybe? I'll use `CR50_BUF_MAXSIZE * 2` ?
https://review.coreboot.org/c/coreboot/+/61720/comment/a7e472e5_e2f44108 PS3, Line 554: get_fw_version
line #499 returns the status but you are not checking this prior to below serial msg ?
Done
https://review.coreboot.org/c/coreboot/+/61720/comment/3e3e6c9d_237e8fe8 PS3, Line 565: }
one blank line please
Done