[coreboot-gerrit] [XS] Change in coreboot[main]: soc/intel/common/block/cpu: Fix number of way computation regression

[Wonkyu Kim (Code Review)]

Attention is currently required from: Jérémy Compostella, Subrata Banik.

Wonkyu Kim has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/83948?usp=email )

Change subject: soc/intel/common/block/cpu: Fix number of way computation regression
......................................................................

Patch Set 6:

(1 comment)

File src/soc/intel/common/block/cpu/car/cache_as_ram.S:

https://review.coreboot.org/c/coreboot/+/83948/comment/89726c04_a23c5e49?usp... :
PS5, Line 526: 	xor	%edx, %edx
> > How does that matter, since line #528 will copy EAX into EDX anyway? […]

I also checked other reference and it looks Jeremey's change is correct.

Refer below part in https://www.aldeid.com/wiki/X86-assembly/Instructions/div

Always divides the 64 bits value across EDX:EAX by a value.

The operation 0x8003 / 0x100 can be written as follows:
mov edx, 0        ; clear dividend
mov eax, 0x8003   ; dividend
mov ecx, 0x100    ; divisor
div ecx           ; EAX = 0x80, EDX = 0x

But can we add comments for reason to clear for readability to avoid confusion?