Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35864 )
Change subject: mb/lenovo/{t60,r60}: Add ThinkPad R60 support as variant board ......................................................................
Patch Set 4:
Patch Set 4:
Patch Set 4:
(2 comments)
Patch Set 4: Code-Review+1
(3 comments)
Patch Set 1:
(3 comments)
I guess you messed up with git, but here are some comments about the gpio.c file.
yea fixed that
No, this is based on a parent that is not on gerrit...
Uhhh, I have written that file from scratch based on schematics and boardview.
No I meant that the hash of the commit before this is not on gerrit. This is changing files that are not on master and are not added by a previous patch...