Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42728 )
Change subject: src/mb: Use macro for access_size
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42728/1/src/mainboard/lenovo/x60/ma...
File src/mainboard/lenovo/x60/mainboard.c:
https://review.coreboot.org/c/coreboot/+/42728/1/src/mainboard/lenovo/x60/ma...
PS1, Line 23: .access_size = ACPI_ACCESS_SIZE_UNDEFINED, \
Thx. […]
A separate clean-up commit would have been nice.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42728
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I275c86ef5833d87378cff1e1bd228776e007dad3
Gerrit-Change-Number: 42728
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 26 Jun 2020 12:28:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment