Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35471 )
Change subject: soc/mediatek/mt8183: Refactor DRAM init by bit fields API ......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35471/14/src/soc/mediatek/mt8183/dr... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/35471/14/src/soc/mediatek/mt8183/dr... PS14, Line 502: 0, : TEST2_4_TESTSSOXTALKPAT, 0,
This is really the reason I prefer to move to new API. […]
Ack
https://review.coreboot.org/c/coreboot/+/35471/14/src/soc/mediatek/mt8183/dr... PS14, Line 532: t2_1 >> 24
nit: Wouldn't it be much better to just change TEST2_1_CAL and friends to not already be shifted in […]
Probably no. t2_1 and t2_2 should be considered as u32 integer in caller (also in params). It is the reg that splits one u32 variable into two fields (in different regs). So I think current form is clear enough (although, the latter TEST2 may be changed to something like (1 << 24 - 1), but 0xffffff is also good enough IMHO.)