build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31280 )
Change subject: mb/google/hatch: Enable Audio support ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/#/c/31280/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/31280/1/src/mainboard/google/hatch/variants/... PS1, Line 69: PAD_CFG_NF(GPP_H8, NONE, DEEP, NF1), code indent should use tabs where possible
https://review.coreboot.org/#/c/31280/1/src/mainboard/google/hatch/variants/... PS1, Line 69: PAD_CFG_NF(GPP_H8, NONE, DEEP, NF1), please, no spaces at the start of a line
https://review.coreboot.org/#/c/31280/1/src/mainboard/google/hatch/variants/... PS1, Line 70: /* PCH_I2C_AUDIO_SCL */ code indent should use tabs where possible
https://review.coreboot.org/#/c/31280/1/src/mainboard/google/hatch/variants/... PS1, Line 71: PAD_CFG_NF(GPP_H9, NONE, DEEP, NF1), code indent should use tabs where possible
https://review.coreboot.org/#/c/31280/1/src/mainboard/google/hatch/variants/... PS1, Line 71: PAD_CFG_NF(GPP_H9, NONE, DEEP, NF1), please, no spaces at the start of a line