14 Apr
2023
14 Apr
'23
9:40 a.m.
Attention is currently required from: Arthur Heymans.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74398 )
Change subject: cpu/intel/speedstep: Refactor P-state coordination ......................................................................
Patch Set 1:
(1 comment)
File src/cpu/intel/speedstep/acpi.c:
https://review.coreboot.org/c/coreboot/+/74398/comment/f86d0bb1_e9dbff87 PS1, Line 66: ((cpuid_eax(1) >> 4) & 0xffff) == 0x1067
sidenote: get_fms() might be nice.
This code should be checked for validity. Is it really about the model or hyperthreading?
--
To view, visit https://review.coreboot.org/c/coreboot/+/74398
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12462f271821d3d8fe3324d84a65c2341729591e
Gerrit-Change-Number: 74398
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 14 Apr 2023 06:40:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment