Attention is currently required from: Patrick Rudolph.
Patrick Georgi has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/30118?usp=email )
Change subject: arch/x86/boot: Jump to payload in protected mode
......................................................................
Patch Set 34:
(1 comment)
File src/include/assert.h:
https://review.coreboot.org/c/coreboot/+/30118/comment/0573b1ac_587613e9?usp... :
PS34, Line 87: (uint32_t)(uintptr_t)(x); \
this line is unreachable, or I'm wrong?
That line is reached when x points at the lower 4GB.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30118?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6552ac30f1b6205e08e16d251328e01ce3fbfd14
Gerrit-Change-Number: 30118
Gerrit-PatchSet: 34
Gerrit-Owner: Patrick Rudolph
rudolphpatrick05@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
rudolphpatrick05@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
rudolphpatrick05@gmail.com
Gerrit-Comment-Date: Mon, 19 Aug 2024 17:52:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr