[coreboot-gerrit] Change in coreboot[master]: soc/nvidia/tegra124: Assert divisor is non-zero

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34572 )

Change subject: soc/nvidia/tegra124: Assert divisor is non-zero
......................................................................

soc/nvidia/tegra124: Assert divisor is non-zero

The logic for the calculation of plld.m is rather complicated, so do a
sanity check that it is non-zero before doing the division.

Change-Id: I60f49b8eed47a3de86713304bde7a4d3f3d935dd
Signed-off-by: Jacob Garber 
Found-by: Coverity CID 1260981
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34572
Tested-by: build bot (Jenkins) 
Reviewed-by: Julius Werner 
Reviewed-by: Paul Menzel 
---
M src/soc/nvidia/tegra124/clock.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Julius Werner: Looks good to me, approved

diff --git a/src/soc/nvidia/tegra124/clock.c b/src/soc/nvidia/tegra124/clock.c
index 6877c04..bb0343d 100644
--- a/src/soc/nvidia/tegra124/clock.c
+++ b/src/soc/nvidia/tegra124/clock.c
@@ -13,6 +13,7 @@
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  */
+#include <assert.h>
 #include <arch/clock.h>
 #include <device/mmio.h>
 #include <console/console.h>
@@ -377,6 +378,7 @@
    	printk(BIOS_WARNING, "%s: Failed to match output frequency %u, "
    	       "best difference is %u.\n", __func__, frequency,
    	       best_diff);
+		assert(plld.m != 0);
    	rounded_rate = (ref / plld.m * plld.n) >> plld.p;
    }