[coreboot-gerrit] [S] Change in coreboot[main]: soc/intel/pantherlake: Update Touch Controller UPD params

[Paul Menzel (Code Review)]

Attention is currently required from: Bora Guvendik, Cliff Huang, Jérémy Compostella, Kapil Porwal, Kyoung Il Kim, Pranava Y N, Subrata Banik.

Paul Menzel has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/85199?usp=email )

Change subject: soc/intel/pantherlake: Update Touch Controller UPD params
......................................................................

Patch Set 5:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85199/comment/a54e4c0c_a99966f9?usp... :
PS5, Line 9: ThcAssignment
ThcAssignment was already set before?

https://review.coreboot.org/c/coreboot/+/85199/comment/5d1220a4_bfcba4a5?usp... :
PS5, Line 9: :
Not needed.

https://review.coreboot.org/c/coreboot/+/85199/comment/393dd811_65b11657?usp... :
PS5, Line 12: modified:   src/soc/intel/pantherlake/chip.h
            : 	modified:   src/soc/intel/pantherlake/fsp_params.c
Not needed, as the Gerrit interface and `git show --stat` show this.

File src/soc/intel/pantherlake/chip.h:

https://review.coreboot.org/c/coreboot/+/85199/comment/35f2bf27_fe8e33b8?usp... :
PS5, Line 517: /* Touch Host Controller Mode
             : 	 * Switch between Intel THC protocol and Industry standard HID Over SPI protocol.
             : 	 * 0x0:Thc, 0x1:Hid, 0x2:I2c
             : 	 */
             : 	uint8_t thc_mode[2];
             : 
             : 	/* Touch Host Controller Wake On Touch
             : 	 * Based on this setting vGPIO for given THC will be in native mode, and additional
             : 	 * _CRS for wake will be exposed in ACPI
             : 	 */
Please use the recommended multi-line comment styles.

https://doc.coreboot.org/contributing/coding_style.html#commenting

https://review.coreboot.org/c/coreboot/+/85199/comment/f62686e9_a5e2592e?usp... :
PS5, Line 527: 	uint8_t thc_wake_on_touch[2];
Why not bool?