Attention is currently required from: Jason Nien, Matt DeVillier, Karthik Ramasubramanian.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67778 )
Change subject: mb/google/skyrim: Implement touchscreen power sequencing
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/skyrim/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/67778/comment/2292bb97_d3b2088d
PS3, Line 116: /* EN_PP3300_TCHSCR */
: PAD_GPO(GPIO_131, LOW),
: /* TCHSCR_RESET_L */
: PAD_GPO(GPIO_136, LOW),
I agree with Karthik that we should add the FW_CONFIG bit for all future devices. […]
Filed b/255965286 to look at adding FW_CFG.
In the meantime, I think we're good here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67778
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4d7ac8f951bb94da2216a24dc85a96275c9d449
Gerrit-Change-Number: 67778
Gerrit-PatchSet: 5
Gerrit-Owner: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 28 Oct 2022 21:33:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment