Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34587 )
Change subject: soc/*: mp_run_on_all_cpus: Remove configurable timeout ......................................................................
Patch Set 7:
(7 comments)
https://review.coreboot.org/c/coreboot/+/34587/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34587/2//COMMIT_MSG@7 PS2, Line 7: soc/mp_init: Fix timeout
Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/34587/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34587/3//COMMIT_MSG@9 PS3, Line 9: s
usually
Done
https://review.coreboot.org/c/coreboot/+/34587/3//COMMIT_MSG@10 PS3, Line 10: it's
its
Done
https://review.coreboot.org/c/coreboot/+/34587/3//COMMIT_MSG@12 PS3, Line 12: most mp_run_on_all_cpus calls
The first call in post_mp_init should never fail as all APs are idle, due to previous synchronisat […]
Done
https://review.coreboot.org/c/coreboot/+/34587/5/src/include/cpu/x86/mp.h File src/include/cpu/x86/mp.h:
https://review.coreboot.org/c/coreboot/+/34587/5/src/include/cpu/x86/mp.h@13... PS5, Line 137: long expire_us
Yes. It's used by agesa wrapper and fsp2.0 mp init ppi, providing their own custom timeout. […]
Done
https://review.coreboot.org/c/coreboot/+/34587/3/src/soc/intel/apollolake/cp... File src/soc/intel/apollolake/cpu.c:
https://review.coreboot.org/c/coreboot/+/34587/3/src/soc/intel/apollolake/cp... PS3, Line 259: 100
was chosen as APs are idle at start of post_mp_init. […]
Done
https://review.coreboot.org/c/coreboot/+/34587/3/src/soc/intel/skylake/cpu.c File src/soc/intel/skylake/cpu.c:
https://review.coreboot.org/c/coreboot/+/34587/3/src/soc/intel/skylake/cpu.c... PS3, Line 494: 100
same
Done