Attention is currently required from: Jakub Czapiga, Jan Dabros. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56601 )
Change subject: tests: Add lib/cbfs-verification-test test case ......................................................................
Patch Set 9:
(4 comments)
File tests/include/tests/lib/cbfs_util.h:
https://review.coreboot.org/c/coreboot/+/56601/comment/6d356f74_3ddfcb0d PS8, Line 74: TEST_REGION(cbfs_cache, TEST_CBFS_CACHE_SIZE);
It is almost the same as for test data files. […]
I mean the definitions for the file_no_hash, file_valid_hash, etc. globals. You define five TEST_DATA blocks in this header, and the only useful thing one can do with them is define CBFS file structures like that (with various attributes), so might make sense to do that in the common mock file already.
File tests/lib/cbfs-verification-test.c:
https://review.coreboot.org/c/coreboot/+/56601/comment/2473d3c9_3c269c7b PS2, Line 4: #define __noreturn
I think so. die() from tests/stubs/die. […]
I mean as long as it works like this without needing weird hacks to redefine the macro, that should be fine.
https://review.coreboot.org/c/coreboot/+/56601/comment/4605193d_38c16442 PS2, Line 181: assert_memory_equal(mapping, &test_data, TEST_DATA_SIZE);
Done
...so are you changing them to pointer comparisons?
File tests/lib/cbfs-verification-test.c:
https://review.coreboot.org/c/coreboot/+/56601/comment/df9fbd91_3afa832a PS8, Line 244: return cmocka_run_group_tests(cbfs_verification_tests, NULL, NULL);
How about adding TEST_NAME define and using it instead? And we could redefine cmocka_run_group_tests […]
Yeah, that should also work