Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36209 )
Change subject: security/vboot/sync_ec: Add timestamps
......................................................................
Patch Set 19:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36209/19/src/commonlib/include/comm...
File src/commonlib/include/commonlib/timestamp_serialized.h:
https://review.coreboot.org/c/coreboot/+/36209/19/src/commonlib/include/comm...
PS19, Line 74: TS_START_HASH_BODY = 507,
: TS_DONE_LOADING = 508,
: TS_DONE_HASHING_FW_MAIN = 509,
Yes, but I liked "BODY" better as the terminology here tbh.
Done
https://review.coreboot.org/c/coreboot/+/36209/19/src/commonlib/include/comm...
PS19, Line 199: { TS_END_HASH_BODY, "finished verifying body signature (RSA)" },
All these timestamps talk about "body" either change them all or none of them (I don't see why it ne […]
It's all the same to me, I'll change it back.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36209
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8
Gerrit-Change-Number: 36209
Gerrit-PatchSet: 19
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 08 Nov 2019 03:34:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Joel Kitching
kitching@google.com
Gerrit-MessageType: comment