Attention is currently required from: Martin Roth, Paul Menzel, Stefan Reinauer.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56213 )
Change subject: payloads: FILO: Hook up autoboot options
......................................................................
Patch Set 2:
(1 comment)
File payloads/external/FILO/Makefile:
https://review.coreboot.org/c/coreboot/+/56213/comment/d67ad0d7_3ded6d8a
PS2, Line 39: echo "CONFIG_AUTOBOOT_FILE=$(CONFIG_FILO_AUTOBOOT_FILE)" >> filo/.config
Sorry for withholding more context. […]
Oh it just looks the same because that's almost the default? :)
Maybe missing quotes? e.g. CONFIG_AUTOBOOT_FILE="hda1:..."
You can either use " or replace the outer ones with single quotes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56213
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id167e9a144bf466da87469108002672b299b702a
Gerrit-Change-Number: 56213
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Tue, 13 Jul 2021 12:31:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment