25 Jul
2019
25 Jul
'19
6:22 p.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34537 )
Change subject: src/device/oprom: Fix bootsplash display code for optionroms ......................................................................
Patch Set 24:
(2 comments)
nice cleanup, thanks!
https://review.coreboot.org/c/coreboot/+/34537/24/src/include/vbe.h File src/include/vbe.h:
https://review.coreboot.org/c/coreboot/+/34537/24/src/include/vbe.h@106 PS24, Line 106: mode_indo mode_info
https://review.coreboot.org/c/coreboot/+/34537/24/src/lib/bootsplash.c File src/lib/bootsplash.c:
https://review.coreboot.org/c/coreboot/+/34537/24/src/lib/bootsplash.c@18 PS24, Line 18: <lib/jpeg.h> "jpeg.h" (as in: search in current directory)?
--
To view, visit https://review.coreboot.org/c/coreboot/+/34537
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ab7b8a0f28badaa16e25dbe807158870d06e26a
Gerrit-Change-Number: 34537
Gerrit-PatchSet: 24
Gerrit-Owner: Johanna Schander coreboot@mimoja.de
Gerrit-Reviewer: Christoph Pomaska github@aufmachen.jetzt
Gerrit-Reviewer: Johanna Schander coreboot@mimoja.de
Gerrit-Reviewer: Jonathan Neuschäfer j.neuschaefer@gmx.net
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 25 Jul 2019 16:22:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment