build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44904 )
Change subject: cpu/x86/mpinit: Serialize microcode updates for HT threads ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44904/5/src/cpu/x86/sipi_vector_c_h... File src/cpu/x86/sipi_vector_c_handler.c:
https://review.coreboot.org/c/coreboot/+/44904/5/src/cpu/x86/sipi_vector_c_h... PS5, Line 40: } else suspect code indent for conditional statements (8, 8)
https://review.coreboot.org/c/coreboot/+/44904/5/src/cpu/x86/sipi_vector_c_h... PS5, Line 56: if (params->microcode_lock_ht) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/44904/5/src/include/cpu/x86/mp.h File src/include/cpu/x86/mp.h:
https://review.coreboot.org/c/coreboot/+/44904/5/src/include/cpu/x86/mp.h@16... PS5, Line 164: spinlock_t hyperthreading_lock[CONFIG_MAX_CPUS/2]; /* Initialize hyperthreading lock here */ line over 96 characters