Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42441 )
Change subject: mb/google/hatch: Set Reset Power Cycle Duration for hatch platforms ......................................................................
Patch Set 3:
(8 comments)
https://review.coreboot.org/c/coreboot/+/42441/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42441/3//COMMIT_MSG@9 PS3, Line 9: Currently, Reset Power Cycle Duration is set with default value(4sec). Please add a space before the (, and use SI unit *s*.
https://review.coreboot.org/c/coreboot/+/42441/3//COMMIT_MSG@11 PS3, Line 11: set sets
https://review.coreboot.org/c/coreboot/+/42441/3//COMMIT_MSG@11 PS3, Line 11: 1sec 1 s
https://review.coreboot.org/c/coreboot/+/42441/3//COMMIT_MSG@16 PS3, Line 16: S3 What does S3 have to do with this?
https://review.coreboot.org/c/coreboot/+/42441/3//COMMIT_MSG@16 PS3, Line 16: 5seconds 5 seconds
https://review.coreboot.org/c/coreboot/+/42441/3//COMMIT_MSG@18 PS3, Line 18: Patch patch
https://review.coreboot.org/c/coreboot/+/42441/3//COMMIT_MSG@19 PS3, Line 19: 2seconds 2 seconds
https://review.coreboot.org/c/coreboot/+/42441/3//COMMIT_MSG@22 PS3, Line 22: p *p* or *b*?