[coreboot-gerrit] [M] Change in coreboot[master]: soc/amd/common/block/spi: Mainboard to override SPI Read Mode

[Karthik Ramasubramanian (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Jason Nien, Matt DeVillier, Jon Murphy, Martin Roth, Fred Reitberger, Felix Held.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68946 )

Change subject: soc/amd/common/block/spi: Mainboard to override SPI Read Mode
......................................................................

Patch Set 1:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/68946/comment/35ce585a_ebb4d25d 
PS1, Line 15: BUG=b:225213679
> This bug was marked dupe, and the one that it's a dupe of was marked won't fix infeasible, is this r […]

Yeah. This bug provides background regarding the hardware limitation mentioned in the CL. There are no other bugs.

File src/mainboard/google/guybrush/spi_speeds.c:

https://review.coreboot.org/c/coreboot/+/68946/comment/fa8da86c_16acebf0 
PS1, Line 7: void mainboard_spi_cfg_override(uint8_t *fast_speed, uint8_t *read_mode)
> Rename variable speed?  It's no longer solely the fast speed

It is still fast_speed only that we are overriding. There are other speeds that are not touched yet.