Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/7/src/mainboard/google/voltee...
PS7, Line 5: chip drivers/i2c/generic
: register "hid" = ""10EC5682""
: register "name" = ""RT58""
: register "desc" = ""Headset Codec""
: register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_F8)"
: # Set the jd_src to RT5668_JD1 for jack detection
: register "property_count" = "1"
: register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER"
: register "property_list[0].name" = ""realtek,jd-src""
: register "property_list[0].integer" = "1"
: device i2c 1a on
: probe AUDIO MAX98357_ALC5682I_I2S
: probe AUDIO MAX98373_ALC5682I_I2S
: end
: end
Done
Dear Zhuohao,
We remove this code audio will not work.
so we add back this code, and remove "MAX98357_ALC5682I_I2S".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42301
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea
Gerrit-Change-Number: 42301
Gerrit-PatchSet: 13
Gerrit-Owner: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-Comment-Date: Tue, 14 Jul 2020 10:59:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Comment-In-Reply-To: Zhuohao Lee
zhuohao@chromium.org
Gerrit-MessageType: comment