Attention is currently required from: Stefan Reinauer, Rizwan Qureshi, Meera Ravindranath, Sridhar Siricilla. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48471 )
Change subject: util/ifdtool: Add an option to set top swap block size ......................................................................
Patch Set 10:
(4 comments)
File util/ifdtool/ifdtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124289): https://review.coreboot.org/c/coreboot/+/48471/comment/1a3af3cc_71453250 PS10, Line 1091: printf("Top swap block size greater than 1MB not supported on this platform.\n"); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124289): https://review.coreboot.org/c/coreboot/+/48471/comment/fac84474_3d7fa2be PS10, Line 1094: else { else should follow close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124289): https://review.coreboot.org/c/coreboot/+/48471/comment/4214dcc0_c2cb857a PS10, Line 1120: switch (platform){ space required before the open brace '{'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124289): https://review.coreboot.org/c/coreboot/+/48471/comment/2b1b3445_4344a4d4 PS10, Line 1867: if (!is_valid_topswap(&new_topswap)) { suspect code indent for conditional statements (24, 40)