Attention is currently required from: Alexander Couzens, Maciej Pijanowski, Michał Kopeć, Paul Menzel.
Elyes Haouas has posted comments on this change by Maciej Pijanowski. ( https://review.coreboot.org/c/coreboot/+/80609?usp=email )
Change subject: mb/lenovo: Add ThinkCentre M920q (Coffee Lake) ......................................................................
Patch Set 10:
(3 comments)
File src/mainboard/lenovo/m920q/bootblock.c:
https://review.coreboot.org/c/coreboot/+/80609/comment/f7917210_4f269b59?usp... : PS10, Line 5: #include <mainboard/gpio.h> : #include <soc/gpio.h> not used if I'm not wrong
File src/mainboard/lenovo/m920q/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80609/comment/ca7f4989_819a7e91?usp... : PS10, Line 33: // I'd use "#" same style used for comments here
File src/mainboard/lenovo/m920q/romstage.c:
https://review.coreboot.org/c/coreboot/+/80609/comment/cdcdc876_4efce30a?usp... : PS10, Line 3: <cf9_reset.h> : #include <console/console.h> : #include <cpu/cpu.h> : #include <cpu/x86/msr.h> : #include <soc/cnl_memcfg_init.h> : #include <soc/romstage.h> : #include <types.h> please check and remove unused includes