Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31544 )
Change subject: commonlib: Add Bubble sort algorithm ......................................................................
Patch Set 2: Code-Review+1
(5 comments)
https://review.coreboot.org/#/c/31544/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31544/2//COMMIT_MSG@9 PS2, Line 9: Integers integers
https://review.coreboot.org/#/c/31544/2//COMMIT_MSG@13 PS2, Line 13: sort are Just one space.
https://review.coreboot.org/#/c/31544/2//COMMIT_MSG@16 PS2, Line 16: need needed
https://review.coreboot.org/#/c/31544/2/src/commonlib/include/commonlib/sort... File src/commonlib/include/commonlib/sort.h:
https://review.coreboot.org/#/c/31544/2/src/commonlib/include/commonlib/sort... PS2, Line 20: typedef enum{ Add a space before {?
https://review.coreboot.org/#/c/31544/2/src/commonlib/sort.c File src/commonlib/sort.c:
https://review.coreboot.org/#/c/31544/2/src/commonlib/sort.c@30 PS2, Line 30: /* Implement a simple Bubble sort algorithm. Reduce the needed number of Please use the allowed comment style. (No idea if clang-format would help.)