Attention is currently required from: Solomon Alan-Dei.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68986 )
Change subject: util/cbfstool/bpdt_formats: Fix memory leak issues ......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68986/comment/948e508e_a32bf664 PS2, Line 11: not integers as was previouly implemented. It also now matches bpdt_1_7.c
Patchset:
PS2: This is very odd. It's unlike Furquan to make this a mistake like this It seems like it had to be intentional, but I don't understand why.
My only thought is that maybe he was thinking that we wouldn't want to create new headers using the older header revision.
Regardless, it seems like this change does the right thing in the situation. If Furquan had really wanted to just skip it completely, the function could just return null regardless.