18 Jul
2024
18 Jul
'24
5:29 a.m.
Attention is currently required from: Julius Werner, Karthik Ramasubramanian, Paul Menzel, Shelley Chen, Subrata Banik.
Ashish Kumar Mishra has posted comments on this change by Ashish Kumar Mishra. ( https://review.coreboot.org/c/coreboot/+/83420?usp=email )
Change subject: vc/google/chromeos: Add configurable compression for logo file in cbfs ......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83420/comment/c61f8182_60b76e4d?usp... : PS5, Line 15: ~760ms
This is too big of savings - almost 1 second. […]
Typo - it's 0.760 ms, i.e. <1ms
--
To view, visit https://review.coreboot.org/c/coreboot/+/83420?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I57fbd0d3a39eaba3fb9d61e7a3fb5eeb44e3a839
Gerrit-Change-Number: 83420
Gerrit-PatchSet: 5
Gerrit-Owner: Ashish Kumar Mishra ashish.k.mishra@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen shchen@google.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Thu, 18 Jul 2024 03:29:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com