Sricharan Ramabadhran has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29950 )
Change subject: soc/qualcomm/qcs405: Add MMU support
......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/#/c/29950/13/src/soc/qualcomm/qcs405/include/soc...
File src/soc/qualcomm/qcs405/include/soc/symbols.h:
https://review.coreboot.org/#/c/29950/13/src/soc/qualcomm/qcs405/include/soc...
PS13, Line 23: #define _ssram_size (_essram - _ssram)
This pattern has recently been replaced, please use DECLARE_REGION() (from <symbols.h>) now.
ok, will do
https://review.coreboot.org/#/c/29950/13/src/soc/qualcomm/qcs405/mmu.c
File src/soc/qualcomm/qcs405/mmu.c:
https://review.coreboot.org/#/c/29950/13/src/soc/qualcomm/qcs405/mmu.c@28
PS13, Line 28: _ssram_size
... […]
ok
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29950
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8c6353be2c0379ec94f91223805762a2286de06d
Gerrit-Change-Number: 29950
Gerrit-PatchSet: 13
Gerrit-Owner: nsekar@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: nsekar@codeaurora.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sricharan Ramabadhran
srichara@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Fri, 08 Mar 2019 11:52:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment