Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43678 )
Change subject: soc/amd/picasso: Don't run dcache_clean_all() in psp_verstage ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43678/4/src/include/reset.h File src/include/reset.h:
https://review.coreboot.org/c/coreboot/+/43678/4/src/include/reset.h@6 PS4, Line 6: e e?
https://review.coreboot.org/c/coreboot/+/43678/4/src/lib/reset.c File src/lib/reset.c:
https://review.coreboot.org/c/coreboot/+/43678/4/src/lib/reset.c@14 PS4, Line 14: board_reset Part of me feels like this whole function should just be made weak or we should replace the compilation unit. This function doesn't really buy us anything other than some logging and a method that needs to be implemented.
We already have a MISSING_BOARD_RESET option, how about we add a new option CUSTOM_BOARD_RESET. When it's set we omit this reset.c file from the build.
For picasso/reset.c we copy this board_reset function over. For psp_verstage/reset.c we copy this function and remove the dcache.
This also means we could move the do_board_reset functionality into the board_reset since we aren't using the lib/reset.c framework anymore.