Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add spds for Eldrid
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44272/4/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44272/4/src/mainboard/google/voltee...
PS4, Line 2: auto-generated
which script generated this? i wish scripts would leave some sort of signature.
https://review.coreboot.org/c/coreboot/+/44272/4/src/mainboard/google/voltee...
PS4, Line 4: src/mainboard/goo
i'd suggest
$(abspath .)
here so we don't hard code the name of the containing directory.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44272
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66
Gerrit-Change-Number: 44272
Gerrit-PatchSet: 4
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mice Lin
mice_lin@wistron.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 07 Aug 2020 01:51:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment