29 Nov
2021
29 Nov
'21
11:12 p.m.
Attention is currently required from: Bao Zheng, Kangheui Won. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59581 )
Change subject: amdfwtool: remove duplicates ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59581/comment/3bc7e8bb_a932bf7c PS1, Line 12: TEST=build guybrush and confirm amdfw and coreboot.rom are identical this needs to be tested on picasso and stoneyridge where it might make a difference. the cezanne fw.cfg file doesn't have .subprog = 1 for any smu firmware file, but picasso and stoneyridge have
--
To view, visit https://review.coreboot.org/c/coreboot/+/59581
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b86e24ba1c2769985e2864528e4dfcbf3cccc4b
Gerrit-Change-Number: 59581
Gerrit-PatchSet: 1
Gerrit-Owner: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Bao Zheng zheng.bao@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Bao Zheng zheng.bao@amd.corp-partner.google.com
Gerrit-Attention: Kangheui Won khwon@chromium.org
Gerrit-Comment-Date: Mon, 29 Nov 2021 22:12:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment