17 Jun
2020
17 Jun
'20
4:59 p.m.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42459 )
Change subject: [RFC] device: Add method for configuring bus master based on config option ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42459/4/src/include/device/pci.h File src/include/device/pci.h:
https://review.coreboot.org/c/coreboot/+/42459/4/src/include/device/pci.h@13... PS4, Line 131: void pci_configure_bus_master(struct device *dev);
Right, maybe do s/enable/request/ then? […]
I would rather use "configure". IMO this relates more to a config option. "request" sounds like there is happening some black magic.
--
To view, visit https://review.coreboot.org/c/coreboot/+/42459
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I876c48ea3fb4f9cf7b6a5c2dcaeda07ea36cbed3
Gerrit-Change-Number: 42459
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 17 Jun 2020 14:59:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment