Tim Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42976 )
Change subject: Configs: Set PCH power policy register to S5
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42976/2/configs/builder/config.ocp....
File configs/builder/config.ocp.deltalake:
https://review.coreboot.org/c/coreboot/+/42976/2/configs/builder/config.ocp....
PS2, Line 18: CONFIG_POWER_STATE_OFF_AFTER_FAILURE=y
Why not add this Kconfig to DeltaLake Kconfig in mainboard directory?
I've tried to add it in mainboard directory, but the power state didn't change to S5. And the way I use is adding "select POWER_STATE_OFF_AFTER_FAILURE" in mainboard directory.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42976
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d4f14bdfc18740976171fd5d369b2d79a916dc4
Gerrit-Change-Number: 42976
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-CC: Rocky Phagura
Gerrit-CC: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Comment-Date: Fri, 03 Jul 2020 06:00:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Gerrit-MessageType: comment