[coreboot-gerrit] Change in ...coreboot[master]: device/pci: Rewrite PCI MMCONF with symbol reference

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31752 )

Change subject: device/pci: Rewrite PCI MMCONF with symbol reference
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/31752/4/src/include/device/pci_mmio_cfg.h 
File src/include/device/pci_mmio_cfg.h:

https://review.coreboot.org/#/c/31752/4/src/include/device/pci_mmio_cfg.h@29 
PS4, Line 29: };
> You can cherry-pick testcases here CB:31811 […]

Thanks. CB:31945 seems to have a similar effect, minus the
reloading of MMCONF_BASE_ADDRESS. Doing the same to the
other writeXX() functions also has some effect, I guess due
to clobbering of uintXX_t in memory? I haven't looked close
at the test cases, yet.

So a combination of the original `extern` pci_mmconf variable
here and adapted `mmio.h` seems feasible.