Attention is currently required from: Nico Huber, Arthur Heymans, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52637 )
Change subject: drivers/pc80/rtc/option.c: Constrain API to integer values ......................................................................
Patch Set 2:
(3 comments)
File src/drivers/pc80/rtc/option.c:
https://review.coreboot.org/c/coreboot/+/52637/comment/b7a1e7ee_a1e95877 PS2, Line 87: enum cb_err cmos_get_int_option(const char *name, int *dest)
Oh, good point. I didn't know this. I'll change it back.
Done
https://review.coreboot.org/c/coreboot/+/52637/comment/98d6d8ed_5cfbf42f PS2, Line 102: if (ce->config == 's')
I just took a quick look at all reserved entries in cmos.layout: […]
Done
File src/include/option.h:
https://review.coreboot.org/c/coreboot/+/52637/comment/f01d6cb0_bfd345dc PS2, Line 25: if (cmos_get_option(&value, name) == CB_SUCCESS)
Yeah, I was thinking about negative numbers as well... I checked the other day, and: […]
CB:52670 CB:52671 CB:52672