Attention is currently required from: Bora Guvendik, Cliff Huang, Jérémy Compostella, Kapil Porwal, Kyoung Il Kim, Pranava Y N.
Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/85199?usp=email )
Change subject: soc/intel/pantherlake: Update Touch Controller UPD params ......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/pantherlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/85199/comment/8ed02cde_35a2a7d1?usp... : PS3, Line 563: if (is_devfn_enabled(PCI_DEVFN_THC0)) { : s_cfg->ThcAssignment[0] = THC_0; : s_cfg->ThcMode[0] = config->thc_mode[0]; : s_cfg->ThcWakeOnTouch[0] = config->thc_wake_on_touch[0]; : } else { : s_cfg->ThcAssignment[0] = THC_NONE; : } : if (is_devfn_enabled(PCI_DEVFN_THC1)) { : s_cfg->ThcAssignment[1] = THC_1; : s_cfg->ThcMode[1] = config->thc_mode[1]; : s_cfg->ThcWakeOnTouch[1] = config->thc_wake_on_touch[1]; : } else { : s_cfg->ThcAssignment[1] = THC_NONE; : } : } ``` if (is_devfn_enabled(PCI_DEVFN_THC0)) { s_cfg->ThcAssignment[0] = THC_0; s_cfg->ThcAssignment[1] = THC_NONE; s_cfg->ThcMode[0] = config->thc_mode[0]; s_cfg->ThcWakeOnTouch[0] = config->thc_wake_on_touch[0]; } else if (is_devfn_enabled(PCI_DEVFN_THC1)) { s_cfg->ThcAssignment[0] = THC_NONE; s_cfg->ThcAssignment[1] = THC_1; s_cfg->ThcMode[1] = config->thc_mode[1]; s_cfg->ThcWakeOnTouch[1] = config->thc_wake_on_touch[1]; } else { s_cfg->ThcAssignment[0] = THC_NONE; s_cfg->ThcAssignment[1] = THC_NONE;
} ```